Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky unit tests fix #48

Merged
merged 10 commits into from
Dec 13, 2023
Merged

Flaky unit tests fix #48

merged 10 commits into from
Dec 13, 2023

Conversation

dusannosovic-ethernal
Copy link

Description

This PR includes changes for flaky UTs

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@Stefan-Ethernal Stefan-Ethernal marked this pull request as ready for review December 13, 2023 07:20
@Stefan-Ethernal Stefan-Ethernal changed the title fix for flaky UT Flaky unit tests fix Dec 13, 2023
@Stefan-Ethernal Stefan-Ethernal merged commit 057c9c3 into develop Dec 13, 2023
8 checks passed
@Stefan-Ethernal Stefan-Ethernal deleted the UT-fix branch December 13, 2023 13:08
bane added a commit that referenced this pull request Mar 14, 2024
* Deploy Network

* Add Permissions

* Minor changes

* Concurrency change

* Destroy Network

* Minor changes

* Minor changes

* Fix commit sha

* Minor changes

* Add Tests

* Disable Tests temporarily

* Nightly Build

* Minor fixes

* Big changes

* Minor changes

* Minor changes

* Minor changes

* Notification fixes

* Notification changes

* Minor changes

* Permissions fixes

* Minor changes

* Notification changes

* Minor changes

* Display commit on notifications

* Minor changes

* Minor fixes

* Logs notification fixes

* Minor changes

* Minor changes

* Minor changes

* Notifications fixes

* Minor changes

* Update actions version

* Deployment fixes

* Minor changes

* Minor changes

* Build repository fixes

* Load Test notification text changes

* EIP-1559; Check if the network is already deployed; Restore Blade Data

* Notifications fixes; Pass blade_repository when deploying the network

* Terraform fixes

* Minor changes

* Minor changes

* Notification fixes

* Notification fixes

* Notification fixes

* Notification fixes

* Notification fixes

* Notification fixes

* Notification fixes

* Notification fixes

* Notification fixes

* Notification fixes

* Notification fixes

* Notification fixes

* Notification fixes

* Notification fixes

* Notification fixes

* Notification fixes

* Notification fixes

* Notification fixes

* Notification fixes

* Notification fixes

* Notification fixes

* Notification fixes

* Notification fixes

* Notification fixes

* Notification fixes

* Notification fixes

* Restore data fixes

* Fix condition

* Fix the RPC URL when the network is already deployed

* Fix the RPC URL when the network is already deployed

* Fix condition

* Fix condition

* Fix condition

* Fix condition

* Fix condition

* Fix condition

* Fix condition

* Fix condition

* Fix condition

* Fix condition

* Fix condition

* Fix condition

* Fix condition

* Fix condition

* Fix condition

* Fix condition

* Fix condition

* Fix condition

* Fix condition

* Fixed when the network is first time deploying

* Fixed upload logs

* Fix: null URL if the network is destroyed but the state file exists

* Main notification changes

* Fix RPC URL; Fix Logs and Data upload

* Minor fix

* Minor fix

* Notification fixes

* Deploy fixes

* Big changes

* Condition fixes

* Version changes

* Test fixes

* Change golangci-lint-action source
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants